pkp/pkp-lib#10874 Remove submission stage from roles installation #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Vitaliy-1
force-pushed
the
i10874_groups_stages
branch
4 times, most recently
from
cec140a to
2ce5460
Compare
Vitaliy-1
commented
Feb 6, 2025
| @@ -45,5 +45,7 @@ module.exports = defineConfig({ | |||
| experimentalRunAllSpecs: true, | |||
| }, | |||
| // Allow cypress to interact with iframes | |||
| chromeWebSecurity: false | |||
| chromeWebSecurity: false, | |||
| viewportWidth: 3024, | |||
There was a problem hiding this comment.
Viewport dimensions appear to be related to test failures. Because of the new UI, especially for the submission workflow page, often it's not enough screen width and/or height to press a button, because it requires scrolling, e.g., to post a submission. scrollIntoView doesn't work reliably in my case. I think this way we can avoid forcing a button click, which we do in several places.
asmecher
approved these changes
Feb 6, 2025
Vitaliy-1
force-pushed
the
i10874_groups_stages
branch
from
2ce5460 to
99ef036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.