Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about language versions #213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

skylarmb
Copy link
Contributor

@skylarmb skylarmb commented May 5, 2021

  • Adds more explicit docker base image versions to avoid breaking changes
  • Adds language version files like .python-version, etc for use with nvm, rbenv, pyenv etc.
  • Adds the engines sections to the node backend and frontend to throw an error if people try to use npm version 7 or an unsupported version of node.
  • Updates readme with specific language versions

Copy link
Contributor

@lindawoo-plaid lindawoo-plaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I'm unfamiliar with the "engines" and what it is used for, but I will investigate...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants