Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about language versions #213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,16 @@ $ make stop language=node

#### Pre-requisites

- The language you intend to use is installed on your machine and available at your command line.
This repo should generally work with active LTS versions of each language such as node >= 14,
python >= 3.8, ruby >= 2.6, etc.
- The backend language you intend to use is installed on your machine and available at your command line.
This repo should generally work with the latest active LTS versions of each language, and language version
files such as `.nvmrc`, `.python-version`, etc are included in each directory for use with popular version management utilities.
- Node 14, npm 6
- Python 3.8
- Ruby 2.7
- Java 16
- Go 1.16
- [Node 14](https://nodejs.org/en/download/) with the default `npm` version 6 (for running the frontend).
- Your environment variables populated in `.env`
- [npm](https://www.npmjs.com/get-npm)
- If using Windows, a command line utility capable of running basic Unix shell commands

#### 1. Running the backend
Expand Down
1 change: 1 addition & 0 deletions frontend/.npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
registry=https://registry.npmjs.com
engine-strict=true
2 changes: 1 addition & 1 deletion frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# pull official base image
FROM node:lts-alpine
FROM node:14-alpine

# set working directory
WORKDIR /app
Expand Down
4 changes: 4 additions & 0 deletions frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"name": "plaid_react_quickstart",
"engines": {
"node": "^14",
"npm": "^6"
},
"version": "0.1.0",
"dependencies": {
"@testing-library/jest-dom": "^5.11.4",
Expand Down
2 changes: 1 addition & 1 deletion go/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.12 AS build
FROM golang:1.16 AS build

WORKDIR /opt/src
COPY . .
Expand Down
1 change: 1 addition & 0 deletions node/.npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
registry=https://registry.npmjs.com
engine-strict=true
4 changes: 2 additions & 2 deletions node/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:alpine
FROM node:14-alpine

WORKDIR /opt/app
RUN chown -R node:node /opt/app
Expand All @@ -11,4 +11,4 @@ COPY --chown=node:node ./node/index.js ./

EXPOSE 8000
ENTRYPOINT ["node"]
CMD ["index.js"]
CMD ["index.js"]
4 changes: 4 additions & 0 deletions node/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"name": "plaid-node-walkthrough",
"engines": {
"node": "^14",
"npm": "^6"
},
"version": "0.1.0",
"description": "A sample app and accompanying walkthrough for the Plaid API.",
"main": "index.js",
Expand Down
1 change: 1 addition & 0 deletions python/.python-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.8.10
2 changes: 1 addition & 1 deletion python/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:alpine
FROM python:3.8-alpine

WORKDIR /opt/app
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion ruby/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:2-alpine
FROM ruby:2.7-alpine

WORKDIR /opt/app
COPY . .
Expand Down
1 change: 1 addition & 0 deletions ruby/Gemfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
source 'https://rubygems.org'
ruby '~> 2.7'

gem 'sinatra'

Expand Down