forked from plantbreeding/brapi-Java-TestServer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from BI Server #2
Open
jloux-brapi
wants to merge
66
commits into
brapi-server-v2
Choose a base branch
from
bi-server-impl
base: brapi-server-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
aa958f9
[BI-1771] - performance experiments
mlm483 d370995
[BI-1771] - added germplasm-related indexes
jloux-brapi 853c4b6
[BI-1771] - reverted index annotation
mlm483 1bafb97
[BI-1771] - reverted whitespace changes
mlm483 511744a
[BI-1771] - made create_indexes.sql idempotent
mlm483 17f208b
[BI-1909] Exploring converting *ToOne relationships to lazy loading a…
timparsons 65f41bb
[BI-1909] NPE fix, converting sysouts to use Logger
timparsons f213636
[BI-1909] Updating GermplasmService to eagerly fetch related date for…
timparsons 444ac44
[BI-1909] suggested changes
timparsons 7ae834a
Create pull.yml
timparsons f3963b0
[BI-1945] - saving work in progress
mlm483 14347ea
[BI-1945] - store additionalInfo on primary entities as JSONB
mlm483 0a6c1c6
[BI-1945] - optimized imports
mlm483 dfe5e82
[BI-1945] - updated template, readme
jloux-brapi 32a1c91
[BI-1945] - cleaned up SQL dummy data migrations
mlm483 c31973b
[BI-1945] - updated template
mlm483 3d73553
[BI-1945] - removed unused class
mlm483 213d51b
[BI-1945] - renamed method
mlm483 ea38550
[BI-1945] - handled null case
mlm483 14d780c
[BI-1945] - added stringtype=unspecified to template
mlm483 027eff8
[BI-1945] - removed debug log
mlm483 2e57478
[BI-1945] - optimized imports
mlm483 246e6a1
[BI-1945] - removed additionalInfo joins
mlm483 44c6a6a
[BI-1945] - updated README.md
mlm483 4d25468
[BI-1945] - added ON DELETE CASCADE to xref linking tables
mlm483 530ae23
[BI-2051] - batched inserts for efficiency
mlm483 1777923
[BI-2051] - removed comment
mlm483 9bb3096
[BI-2040] The fetchScaleValidValueCategories() method was causing the…
davedrp dc3aa96
[BI-2040] removed all calls to fetchXXXXX(page) and the methods thems…
davedrp f3c8871
[BI-2040] removed unused import-statements from ObservationVariableSe…
davedrp b850578
[BI-2078] - made performance improvements (thanks BrapiCoordinatorSelby)
mlm483 0c226fb
Filter out pedigree nodes with null germplasm
nickpalladino af5e584
Updated comment
nickpalladino f02603a
[BI-2109] - added migration for datasets
mlm483 df79493
[BI-2109] - made migration safer
mlm483 d2c9401
[BI-2304] - added migrations for list position
mlm483 ad9ae52
[BI-2304] - fixed migration
mlm483 38978d3
[BI-2304] - preserve list order without changing API
mlm483 1409352
[BI-2304] - used zero-indexing in migration
mlm483 e2548a7
[BI-2304] - changes based on review
mlm483 8281201
create batch entity and controller endpoints
dmeidlin 92aa47f
json deserialize searchrequest sub-types
dmeidlin 7b6b61a
return batchDbID in POST batches response results
dmeidlin e74184b
refactor
dmeidlin 5c00c3d
add constraint to cascade on delete for list_item
dmeidlin beb95c4
add soft_deleted column to list tables
dmeidlin 9ebbfb1
modify list repository to include clause softDelete=falsee
dmeidlin ed8ee46
use where clause and transactional annotations
dmeidlin 0c38c55
soft-delete batch lists
dmeidlin 0191666
add hard delete of single trial
dmeidlin 0547cbc
create hard-delete endpoint for single sample
dmeidlin d659040
cascade delete for trial and sample
dmeidlin 0d4ac86
add soft_delete columns to trial and sample related tables
dmeidlin fc10679
create sample service soft-delete method
dmeidlin aa8b86f
add soft-delete method to trial service
dmeidlin a5d8656
create Trial and Sample components
dmeidlin b96e1c9
optimize imports
dmeidlin f2036bf
respond with 204 for successful delete
dmeidlin cbdd0f3
return entity dbids in response for POST deleteBatch
dmeidlin 493f88f
add batchDeleteDbId query param to GET endpoints for lists, trials, s…
dmeidlin 6fa2c21
create new exception class for wrong batch delete type
dmeidlin 71cdbb1
delete batch entity when deleting batch contents
dmeidlin bd2b039
add cascade delete constraints for study foreign keys
dmeidlin 0efca81
rename batch to batch delete
dmeidlin b57a17d
Solve dummy data migration issues
jloux-brapi b7ecfda
Merge pull request #75 from plantbreeding/keycloak-dev-docker
jloux-brapi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to get the feeling these soft queries could be generified. Not sure why we need to define them in every entity that needs them. I suppose maybe it's bc not every entity necessarily has this column, but I think we could employ some kind of repo inheritance for entities that need deletion, this repo could extend from
BrAPIRepository
, and it contains these soft deleted methods generified for any entity that needs them.