-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @metalsmith/permalinks
to 2.5.1
#522
Update @metalsmith/permalinks
to 2.5.1
#522
Conversation
Remove commented code.
Wow, it's been a while since this repo had up to date dependencies. You're a life-saver, @epreston! 🙏 |
I'll get onto that. We might need to drop on of the 3rd party plugins for metalsmith that formats the final output. We could replace it with |
I think I know what to do there. |
Revert ? This might take an hour or two. |
It's fine. We don't have any deployments planned. 😄 |
I did a winmerge compare after the fix. There are some differences but they all look like content differences. |
Looks like the non English languages are getting duplicate navigation menus ? |
fix issue introduced in #522 The ordering of the plugins requires localization to run before tutorials.
Updates the
@metalsmith/permalinks
plugin to 2.5.1Adjusts metalsmith plugin order and adopts the replacement for the
path
attribute,permalinks
.Fixes: #521
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.