Add skinning support to glTF exporter #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Dec 16, 2024
| @@ -472,6 +478,12 @@ class GltfExporter extends CoreExporter { | |||
| const entityMeshInstance = resources.entityMeshInstances.find(e => e.node === entity); | |||
| if (entityMeshInstance) { | |||
| node.mesh = resources.entityMeshInstances.indexOf(entityMeshInstance); | |||
|
|
|||
| // Add skin reference if this node has a skinned mesh | |||
| const meshInstance = entityMeshInstance.meshInstances[0]; | |||
There was a problem hiding this comment.
Slight problem here is that the engine supports different skin for each mesh instance in the array here, but glTF does not.
We should check all meshInstances in this array, and they must point to the same skin. If they point to different skins, or some do not link to any skin, we should probably log a warning and skip skinning.
There was a problem hiding this comment.
Hmm. Any objection to opening a new issue on this and fixing it in a follow up PR? I want to keep this PR reasonably simple and there might be some nuance to how we want to deal with the case you mention.
mvaligursky
reviewed
Dec 16, 2024
mvaligursky
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for exporting of skins to glTF.
Fixes #7144
Partially addresses #5001
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.