One row for all #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported Assessment Template alters the set of valid importable columns, therefore it should be processed before any custom attributes.
Forward references (refer row2 in mapping column of row1) are forbidden by the current spec, while backward references (refer row1 in mapping column of row2) are easier to support than to forbid in the current state.
It's wrong to generate "created" then "modified" revisions for new imported objects. This commit fixes all tests which imply duplicate revisions.
The whole set of fields takes over 100 megabytes of memory for 1000 CADs and like 20 Custom Roles.
At a later point we'll need to reference it from inside row converter
New error format only needs to know the row ignored and the row processed which shared the same unique value. This commit removes the whole old mechanism of duplicate check and the fields and methods that become unused.
Changes done: - object manipulation logic moved to row converter - methods in row converter reorganized - only one commit per row now - snapshots generated with an explicit call before commit (instead of calling all after_commit hooks)
Both handler and block/row converter contain logic to detect duplicates
aleh-rymasheuski
force-pushed
the
one_row_for_all
branch
from
d31edb7 to
d6b8361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.