Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One row for all #5

Open
wants to merge 13 commits into
base: one_row_for_all_2
Choose a base branch
from
Open

One row for all #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ca6afef
Make sure to import Template before any CA columns
aleh-rymasheuski Jun 27, 2018
eeec28f
Rewrite inter-row mappings test
aleh-rymasheuski Jun 27, 2018
a1a7005
Fix tests expecting 2 revisions for imported objects
aleh-rymasheuski Jun 27, 2018
59a5e9d
Load meta only for mandatory and listed columns
aleh-rymasheuski Jun 27, 2018
7d3c1ee
Hide block import sequence into block converter
aleh-rymasheuski Jun 28, 2018
6b8d48a
Move a constant under its class
aleh-rymasheuski Jun 28, 2018
4e9b868
Collect row import info row by row
aleh-rymasheuski Jun 28, 2018
7edda24
Process row converters as generator in import
aleh-rymasheuski Jun 28, 2018
1a9c327
Process duplicates for unique columns row by row
aleh-rymasheuski Jun 28, 2018
25cbe08
Move row import logic into row converter
aleh-rymasheuski Jun 28, 2018
9a1d3ba
Avoid duplicate errors for non-unique values
aleh-rymasheuski Jun 28, 2018
48a844b
Update tests for non-unique values to new error
aleh-rymasheuski Jun 28, 2018
d6b8361
Move pre-commit checker into row converter
aleh-rymasheuski Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/ggrc/converters/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class ImportConverter(BaseConverter):
"delete",
"task_type",
"audit",
"assessment_template",
]

def __init__(self, dry_run=True, csv_data=None):
Expand Down Expand Up @@ -81,15 +82,10 @@ def import_csv_data(self):
revision_ids = []

for converter in self.initialize_block_converters():
converter.row_converters_from_csv()
for attr_name in self.priority_columns:
converter.handle_row_data(attr_name)
converter.handle_row_data()
converter.import_objects()
converter.import_secondary_objects()

if not converter.ignore:
converter.import_csv_data()
revision_ids.extend(converter.revision_ids)
self.response_data.append(converter.get_info())
revision_ids.extend(converter.revision_ids)

self._start_compute_attributes_job(revision_ids)
self.drop_cache()
Expand Down
Loading