Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Upgrade a Running Network #38

Merged
merged 12 commits into from
Sep 23, 2024
Merged

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Upgrade a Running Network #38

merged 12 commits into from
Sep 23, 2024

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Sep 17, 2024

The "Upgrade a Running Network" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-blockchain/upgrade-a-running-network/

@0xLucca 0xLucca requested a review from nhussein11 September 17, 2024 19:50
github-actions[bot]
github-actions bot reviewed Sep 17, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

Scan for Vale false positives. Resolved convos = made it on the update list and should go away now. I left comments for the legit flags with suggested edits. Thank you!

@CrackTheCode016 CrackTheCode016 self-requested a review September 18, 2024 20:13
CrackTheCode016
CrackTheCode016 reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the content looks good to me, provided a few questions are answered. My main concerns are maintaining the snippets pertaining to the runtime, and also knowing the context of the tutorial.

tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 self-requested a review September 19, 2024 20:14
CrackTheCode016
CrackTheCode016 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides putting the code into snippets, I would overall approve the content in this PR as-is.

eshaben
eshaben reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet! Almost there

...ode/tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network/config-trait-impl.rs Outdated Show resolved Hide resolved
...code/tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network/fs-runtime-macro.rs Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 23, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Show resolved Hide resolved
eshaben
eshaben reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a few things in my last review! Sorry!

tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/upgrade-a-running-network.md Outdated Show resolved Hide resolved
eshaben
eshaben approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks!

@eshaben eshaben merged commit 3844e98 into master Sep 23, 2024
1 check failed
@eshaben eshaben deleted the 0xlucca/psdk-bab-upgrade-network branch September 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawnkelly09 dawnkelly09 dawnkelly09 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

@eshaben eshaben eshaben approved these changes

@nhussein11 nhussein11 Awaiting requested review from nhussein11

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xLucca @dawnkelly09 @eshaben @CrackTheCode016