-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impish: Emit sidebar-activated
on when selection item in Desktop sidebar
#202
Conversation
This is working to make the Desktop panels accessible in a narrow view. I'm seeing a couple of quirks.
Double-clicking does bring me back in, but that feels inconsistent since I didn't need to double-click the first time.
It is horizontally scrollable, but seems like maybe it should break vertically instead of looking like this? (None of the other Desktop pages have to horizontally scroll.) |
c3b6c5c
to
02f7765
Compare
Good catch. Updated to use
Sounds good to me. See pop-os/theme-switcher#29 and pop-os/desktop-widget#73. Since that's used as a shared library, that can be reviewed separately and doesn't block this PR, so this should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is an improvement over current behavior, at @jackpot51's request, I've opened #203 to track the remaining navigation issue and am approving this partial fix.
Fixes #195