Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impish: Emit sidebar-activated on when selection item in Desktop sidebar #202

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Nov 18, 2021

Fixes #195

@ids1024 ids1024 requested review from a team November 18, 2021 17:06
@jackpot51 jackpot51 linked an issue Nov 18, 2021 that may be closed by this pull request
@jacobgkau
Copy link
Member

This is working to make the Desktop panels accessible in a narrow view. I'm seeing a couple of quirks.

  • If I go into a page, then go back to the list, clicking the title again doesn't bring me back into that page:

gcc-pr202-gif1

Double-clicking does bring me back in, but that feels inconsistent since I didn't need to double-click the first time.

  • The Appearance page's theme switcher is cut off:

Screenshot from 2021-11-18 12-02-53

It is horizontally scrollable, but seems like maybe it should break vertically instead of looking like this? (None of the other Desktop pages have to horizontally scroll.)

ids1024 added a commit to pop-os/theme-switcher that referenced this pull request Nov 19, 2021
@ids1024 ids1024 force-pushed the desktop-panel_impish branch from c3b6c5c to 02f7765 Compare November 19, 2021 20:19
@ids1024
Copy link
Member Author

ids1024 commented Nov 19, 2021

If I go into a page, then go back to the list, clicking the title again doesn't bring me back into that page:

Good catch. Updated to use row-activated signal instead of row-selected, just like the Applications panel. Should work as expected now.

It is horizontally scrollable, but seems like maybe it should break vertically instead of looking like this?

Sounds good to me. See pop-os/theme-switcher#29 and pop-os/desktop-widget#73.

Since that's used as a shared library, that can be reviewed separately and doesn't block this PR, so this should be good now.

@jacobgkau
Copy link
Member

After navigating into any of the Desktop sub-pages and then back to the topmost page list, accessing the Desktop section again goes straight to the General page instead of the Desktop list:
desktop-page-selection

This does not happen with the Privacy section:
privacy-page-selection

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is an improvement over current behavior, at @jackpot51's request, I've opened #203 to track the remaining navigation issue and am approving this partial fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Desktop" Settings Can't Be Accessed in Narrow View
4 participants