add deployment scripts #31
Conversation
rkaminsk
force-pushed
the
feature/deploy
branch
from
59beadd to
b3122e6
Compare
rkaminsk
force-pushed
the
feature/deploy
branch
from
f1538ca to
3ccd420
Compare
|
Just going to merge to get it off the table. If further changes are required, we can just open a PR. |
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 <author> | |||
| Copyright (c) 2024 Mister Fillname | |||
There was a problem hiding this comment.
Miss Fillname ? @rkaminsk
There was a problem hiding this comment.
But I think <author> was also okay.
There was a problem hiding this comment.
It's intended. It will be replaced by the init script.
There was a problem hiding this comment.
With <author> it might still have worked. But for example with <email> the tests failed because <email> did not have the proper form.
The only reason why I did the change was to give everything a form as it would occur in a real project to be able to test the project. It was not even intended as a joke. I just wanted to have Fillname in here to have unique token to replace. We can also use Fillname Author or similar if you think that is better.
There was a problem hiding this comment.
Ah, and now I also understand your comment as you wanted the template to be fit the regular expressions.
But I still don`t get why this could be useful. To test the project-template one would simply choose 4 fake things and then test for them?
There was a problem hiding this comment.
Ah, and now I also understand your comment as you wanted the template to be fit the regular expressions. But I still don`t get why this could be useful. To test the project-template one would simply choose 4 fake things and then test for them?
If we use these values, the test workflow will fail because the project template cannot be installed (which is required for testing). The test workflow also runs for the template.
There was a problem hiding this comment.
We could make the values a bit more consistent:
[email protected]
Author Fillname
https://fillname.org/
fillname
There was a problem hiding this comment.
OK, I tried to replace it the way I suggested in my own project and could see the error you meant. Basically the pyproject.toml isnt able to install a project called "".
https://github.com/MaxOstrowski/test-template/
Not sure this is a bad thing though. It prevents the user from using the project without executing init.py first.
On the other hand it's not looking too nice if the CI test in the template repo fail.
Maybe your more consistent set of names is a good tradeoff.
There was a problem hiding this comment.
Maybe your more consistent set of names is a good tradeoff.
I think it is. Having the ci tests running, will ensure that we do not have unnecessary errors in the python code as we continue extending the template.
We could also extend the CI tests to run the init script but that would be a bit cumbersome to implement.
The current approach is an easy workaround with somewhat curios placeholders that is otherwise nice and simple.
TODO