-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change GroovyScriptExtension.load to use a map of context objects instead of a ComputationManager to be more generic #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of a ComputationManager to be more generic Signed-off-by: Nicolas Rol <[email protected]>
This was referenced Feb 5, 2025
geofjamg
requested changes
Feb 25, 2025
...cripting/src/main/groovy/com/powsybl/loadflow/scripting/LoadFlowGroovyScriptExtension.groovy
Outdated
Show resolved
Hide resolved
scripting-test/src/main/java/com/powsybl/scripting/test/AbstractGroovyScriptTest.java
Outdated
Show resolved
Hide resolved
scripting/src/main/groovy/com/powsybl/scripting/groovy/GroovyScripts.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <[email protected]>
something similar must be done for ActionDslLoader |
…make use of contextObjects Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
olperr1
requested changes
Mar 3, 2025
action-ial/action-ial-dsl/src/main/groovy/com/powsybl/action/ial/dsl/ActionDslLoader.groovy
Show resolved
Hide resolved
scripting/src/main/groovy/com/powsybl/scripting/groovy/LogsGroovyScriptExtension.groovy
Show resolved
Hide resolved
scripting/src/main/java/com/powsybl/scripting/groovy/GroovyScriptExtension.java
Show resolved
Hide resolved
action-ial/action-ial-dsl/src/main/groovy/com/powsybl/action/ial/dsl/ActionDslLoader.groovy
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
olperr1
approved these changes
Mar 3, 2025
geofjamg
approved these changes
Mar 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
GroovyScriptExtension.load
expect only a ComputationManager, it is not possible to give other objects that would be used in the binding of groovy scripts.The issue was raised with a Class implemented in powsybl-metrix could not be used in a script through powsybl-afs since the binding could not be made using the GroovyScriptExtension system.
What is the new behavior (if this is a feature change)?
GroovyScriptExtension.load
now expect aMap<Class<?>, Object>
instead so that each extension implementing GroovyScriptExtension can find their specific object inside.Note: in
ActionDslLoader.groovy
, theGroovyScriptExtension
found in the classpath are now loaded with the provided map of context objects. This map will be empty if not provided (and therefore it will not change anything for the users).Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Classes implementing GroovyScriptExtension have to change their method
void load(Binding binding, ComputationManager computationManager)
tovoid load(Binding binding, Map<Class<?>, Object> contextObjects)
If the
computationManager
was used inside, it now has to be found in the map.See for example how the LoadFlowGroovyScriptExtension changes from:
to:
Other information: