Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle optimizers #302

Merged
merged 14 commits into from
Dec 13, 2023
Merged

Handle optimizers #302

merged 14 commits into from
Dec 13, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 2, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Handles optimizers implemented in private version

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Dependent on #300 for reporter implementation

@Lisrte Lisrte self-assigned this Nov 2, 2023
Add getParameter to ParametersSet

Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte force-pushed the handle_optimizers branch from f8912ff to 06812f5 Compare November 3, 2023 14:24
Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte force-pushed the handle_optimizers branch from 1d5f29f to b200dbb Compare November 3, 2023 16:31
@Lisrte Lisrte marked this pull request as ready for review November 14, 2023 10:08
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 0b8c46d into main Dec 13, 2023
6 checks passed
@flo-dup flo-dup deleted the handle_optimizers branch December 13, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants