Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynawo logs #354

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Add dynawo logs #354

merged 9 commits into from
Jul 2, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented May 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #306

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

DynaWaltzParameters dumpFileParameters field is now set by default with DumpFileParameters.createDefaultDumpFileParameters().
Method DynaWaltzParameters.setDefaultDumpFileParameters() has been removed.

Lisrte added 6 commits May 27, 2024 16:49
Refactor DynaWaltzParameters::load

Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte force-pushed the add_dynawo_logs branch from 44d5c85 to 771ac17 Compare May 27, 2024 14:52
@Lisrte Lisrte marked this pull request as ready for review May 27, 2024 14:54
@Lisrte Lisrte requested a review from flo-dup May 27, 2024 14:54
Lisrte added 3 commits May 30, 2024 10:53
Add documentation
Remove setDefaultDumpFileParameters

Signed-off-by: lisrte <[email protected]>
Copy link

@Lisrte Lisrte added the Breaking Change API is broken label Jul 2, 2024
@flo-dup flo-dup merged commit 8be2853 into main Jul 2, 2024
7 checks passed
@flo-dup flo-dup deleted the add_dynawo_logs branch July 2, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure other appenders in the jobs file
2 participants