-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models documentation #367
Merged
Merged
Models documentation #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return formatted doc in DynamicModelGroovyExtension::getModelNames Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
flo-dup
reviewed
Jun 26, 2024
dynawaltz/src/main/java/com/powsybl/dynawaltz/builders/ModelConfigsLibsInfo.java
Outdated
Show resolved
Hide resolved
Add ModelInfo interface Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
# Conflicts: # dynawaltz/src/main/java/com/powsybl/dynawaltz/builders/ModelConfigLoaderImpl.java
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Add EventModelInfo Signed-off-by: lisrte <[email protected]>
flo-dup
reviewed
Jul 17, 2024
dynawaltz/src/main/java/com/powsybl/dynawaltz/builders/ModelConfigs.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <[email protected]>
flo-dup
reviewed
Jul 17, 2024
dynawaltz/src/main/java/com/powsybl/dynawaltz/builders/ModelConfigs.java
Outdated
Show resolved
Hide resolved
ModelConfigs::getModelsName returns unmodifiableSet Signed-off-by: lisrte <[email protected]>
flo-dup
approved these changes
Jul 17, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
Add model documentation 'doc' field in JSON
Documentation is accessible from models builder and itools
Rename
lib
(ortag
event model) tomodelName
whenlib
oralias
is used :lib
valueDoes this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Replace every builders
getSupportedLibs
withgetSupportedModelInfos
:getSupportedModelInfos
returns a collection ofModelInfo
ModelInfo::name
Replace
BuilderConfig
getLibs
withgetModelInfos
.Replace every event builders
getTag
withgetModelName
and add a staticgetEventModelInfo
Replace
EventBuilderConfig
getTag
withgetEventModelInfo
.