Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Generator Inheritance #378

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Refactor Generator Inheritance #378

merged 2 commits into from
Sep 11, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Sep 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #221

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Remove GeneratorFictitious and replace it with BaseGenerator
Change SynchronousGenerator extension with BaseGenerator

Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte changed the title Refactor Generatot Refactor Generator Inheritance Sep 10, 2024
Signed-off-by: lisrte <[email protected]>
Copy link

sonarcloud bot commented Sep 10, 2024

@Lisrte Lisrte requested a review from flo-dup September 10, 2024 13:48
@flo-dup flo-dup merged commit 9666e7f into main Sep 11, 2024
7 checks passed
@flo-dup flo-dup deleted the generator_inheritance_tree branch September 11, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep inheritance tree
2 participants