Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynawo final state values #381

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Dynawo final state values #381

merged 8 commits into from
Oct 1, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Sep 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #357

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Implementation of core PR #3142
Add an OutputType (Curve or FSV) to DynawoCurvesBuilder
Handle FSV in CurvesJsonDeserializer
Add the keyword fsv to Groovy DSL
Renaming of the all curve input classes to OutputVariable

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Renaming of input curves to outputVariables:

  • DynawoCurve to DynawoOutputVariable
  • DynawoCurvesBuilder to DynawoOutputVariablesBuilder
  • CurvesJsonDeserializer to OutputVariablesJsonDeserializer
  • DynawoCurveGroovyExtension to DynawoOutputVariableGroovyExtension

Other information:

Rename curve to outputVariable

Signed-off-by: lisrte <[email protected]>
Add Fsv handling in integration test
Curve renaming 2

Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte added the Breaking Change API is broken label Sep 23, 2024
@Lisrte Lisrte marked this pull request as ready for review September 23, 2024 14:28
@Lisrte Lisrte requested a review from flo-dup September 23, 2024 14:28
@flo-dup flo-dup changed the base branch from main to core_6_5_0_RC1 October 1, 2024 08:26
@flo-dup flo-dup force-pushed the dynamic_simulation_fsv branch from 03ae1f9 to 28aae42 Compare October 1, 2024 08:30
Copy link

sonarcloud bot commented Oct 1, 2024

@flo-dup flo-dup merged commit 2b6a07f into core_6_5_0_RC1 Oct 1, 2024
7 checks passed
@flo-dup flo-dup deleted the dynamic_simulation_fsv branch October 1, 2024 09:18
flo-dup added a commit that referenced this pull request Oct 8, 2024
* Bump powsybl-core to 6.5.0-RC1
* Bump security-analysis version references to 1.7
* Dynawo final state values (#381)

Signed-off-by: Florian Dupuy <[email protected]>
Co-authored-by: Lisrte <[email protected]>
@flo-dup flo-dup mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsv inputs
2 participants