Hvdc var name handler #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turning event and Connection point var name. Signed-off-by: lisrte <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
approved these changes
Oct 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Both Hvdc P and Vsc use an event var name supplier returning var name specific to each model.
Connection point var name should have the same system but at the moment Hvdc P var name is used by both models.
What is the new behavior (if this is a feature change)?
Replace Hvdc event var name supplier with
HvdcVarNameHandlerclass returning event and Connection point var name.Does this PR introduce a breaking change or deprecate an API?