Refactor Dynawo constants #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove constants duplicate Move DynawoSimulationParameters.ExportMode to commons Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
flo-dup
requested changes
Nov 6, 2024
commons/src/main/java/com/powsybl/dynawo/commons/DynawoConstants.java
Outdated
Show resolved
Hide resolved
Replace "/" in DynawoConstants paths with File.separator Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
flo-dup
approved these changes
Nov 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Refactor
What is the current behavior?
What is the new behavior (if this is a feature change)?
Merge the 2
DynawoSimulationConstantsclassesRemove constants duplicate
Move
DynawoSimulationParameters.ExportModeto commonsDoes this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Replace
com.powsybl.dynawo.DynawoSimulationParameters.ExportModewithcom.powsybl.dynawo.commons.ExportModeOther information: