Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model builders #401

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Refactor model builders #401

merged 2 commits into from
Nov 6, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 4, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Add getDefaultModelInfo to Dynamic model builders
Event builder returns ModelInfo instead of EventModelInfo

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Event builder returns ModelInfo instead of EventModelInfo

Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte self-assigned this Nov 4, 2024
@Lisrte Lisrte requested a review from flo-dup November 4, 2024 14:02
@flo-dup flo-dup enabled auto-merge (squash) November 6, 2024 16:50
Copy link

sonarqubecloud bot commented Nov 6, 2024

@flo-dup flo-dup merged commit 79a2902 into main Nov 6, 2024
7 checks passed
@flo-dup flo-dup deleted the refactor_builders branch November 6, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants