Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build PreContingencyResult from Dynawo result #409

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

In dynamic SA a base scenario is always launched before the contingencies' ones, but its result is never used for PreContingencyResult creation.
Instead, the limit violations are checked via the Security API and PreContingencyResult::status is always set to CONVERGED.

What is the new behavior (if this is a feature change)?
Build PreContingencyResult from the base dynamic SA scenario results (aggregatedResults.xml and constraints files)

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@Lisrte Lisrte self-assigned this Nov 15, 2024
@Lisrte Lisrte requested a review from flo-dup November 15, 2024 15:54
Base automatically changed from bus_disconnection to dsa_contingencies_results_fix December 12, 2024 11:47
@flo-dup flo-dup force-pushed the dsa_contingencies_results_fix branch from e129426 to dda6aec Compare December 12, 2024 15:15
Base automatically changed from dsa_contingencies_results_fix to main December 12, 2024 15:19
@flo-dup flo-dup force-pushed the pre_contingency_result_build branch from da439c4 to 2352f3a Compare December 12, 2024 15:29
@flo-dup flo-dup enabled auto-merge (squash) December 12, 2024 15:31
Copy link

sonarcloud bot commented Dec 12, 2024

@flo-dup flo-dup merged commit ce17eb5 into main Dec 12, 2024
8 checks passed
@flo-dup flo-dup deleted the pre_contingency_result_build branch December 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants