Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative Tap Changer Builder side setter #411

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 20, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix / feature

What is the current behavior?

TapChangerAutomationSystemBuilder has only one setter side taking anTransformerSide enum as argument.
This setting work with Groovy DSL supplier but the DynawoModelsSupplier cannot use it since the type of each property has to be specified with an PropertyType.

What is the new behavior (if this is a feature change)?
Since the TransformerSideenum is rather specific, we add a new TapChangerAutomationSystemBuilder::side with String argument.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@Lisrte Lisrte self-assigned this Nov 20, 2024
@Lisrte Lisrte requested a review from flo-dup November 20, 2024 14:05
@flo-dup flo-dup merged commit 0a7ccdf into main Dec 12, 2024
8 checks passed
@flo-dup flo-dup deleted the tap_changer_transformer_side branch December 12, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants