Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove equipment dynamic model id setter #429

Open
wants to merge 5 commits into
base: margin_calculation
Choose a base branch
from

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Feb 18, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

Equipment dynamic model id setting is optional, if not set the dynamicModelId is set to the equipment id.

What is the new behavior (if this is a feature change)?
Equipment dynamic model id is no longer possible and dynamicModelId is always equal to the equipment id.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Remove dynamicModelId setter in DynamicModelsSupplier implementation and EquipmentModelBuilder.

Other information:

@Lisrte Lisrte added the Breaking Change API is broken label Feb 18, 2025
@Lisrte Lisrte self-assigned this Feb 18, 2025
@Lisrte Lisrte changed the title Remove equipment dynamic model is setter Remove equipment dynamic model id setter Feb 24, 2025
@Lisrte Lisrte force-pushed the remove_equipment_dynamic_model_id branch from 4a87133 to 9fc601b Compare February 24, 2025 13:36
@Lisrte Lisrte requested a review from flo-dup February 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
Status: Waiting for review
Development

Successfully merging this pull request may close these issues.

1 participant