Redo Typescript migration #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Tristan-WorkGH
force-pushed
the
fixing_types
branch
from
93f87ae to
50e5063
Compare
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Tristan-WorkGH
force-pushed
the
fixing_types
branch
from
50e5063 to
184ea42
Compare
Tristan-WorkGH
force-pushed
the
fixing_types
branch
from
9ac95b7 to
0196912
Compare
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Tristan-WorkGH
force-pushed
the
fixing_types
branch
from
0196912 to
5ad261c
Compare
FranckLecuyer
approved these changes
Dec 13, 2024
Tristan-WorkGH
force-pushed
the
fixing_types
branch
from
e4b40df to
718a99a
Compare
seem that tsc still check json now?... Signed-off-by: Tristan Chuine <[email protected]>
Tristan-WorkGH
force-pushed
the
fixing_types
branch
from
20a0137 to
c49289e
Compare
amarant
reviewed
Dec 20, 2024
src/components/network-map-viewer/network/layers/arrow-layer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
Signed-off-by: Tristan Chuine <[email protected]>
amarant
approved these changes
Jan 13, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#131
What kind of change does this PR introduce?
Re-apply fixed types of #121, with minimal changes of code outside of types (lots of
@ts-ignoreas consequence).What is the current behavior?
Some classes & components in JS, and some .d.ts not in sync with JS.
What is the new behavior (if this is a feature change)?
All files migrated to TypeScript with the types fixed and unified.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
The migration steps are described in the following sectionWhat changes might users need to make in their application due to this PR? (migration steps)
The API is the same but the types has been updated.
Other information:
@danmarshall/deckgl-typingshas been added temporally, the migration to deck.gl v9 coming soon, and thepostinstallscript is to cancel the copy of files that thepostinstallofdeckgl-typingsis doing (copying files innode_modules/@types/) because it conflict with deck.gl typing preview (look atdeckgl.d.ts).