Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create OLF Knitro AC solver extension #1

Merged
merged 59 commits into from
Dec 16, 2024
Merged

Create OLF Knitro AC solver extension #1

merged 59 commits into from
Dec 16, 2024

Conversation

jeanneArchambault
Copy link
Contributor

@jeanneArchambault jeanneArchambault commented Nov 29, 2024 •
edited by jeandemanged
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Adding the Knitro solver extension for the inner loop formulation of the load flow problem

Does this PR introduce a breaking change or deprecate an API?

  • No

@jeanneArchambault
OLF knitro solver extension
70a35be 
Signed-off-by: jarchambault <[email protected]>
jeanneArchambault and others added 11 commits November 29, 2024 15:09
@jeanneArchambault
Add target in gitignore
4ba4d36 
Signed-off-by: jarchambault <[email protected]>
@jeandemanged
remove target folder
5bc4874 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
checkstyle fix
d4e63dc 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
add logback-test
2b8c66d 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
move to package com.powsybl.openloadflow.knitro.solver
6c52e31 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
clean
3fa44e9 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
clean
5615319 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
add PowsyblOpenLoadFlowKnitroSolverVersion
09ebcce 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
rename ExternalSolverExtensionParameters to KnitroLoadFlowParameters
b708bca 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
maven wrapper and CI
41b51e4 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
fix mvnw permissions
0d96433 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged jeandemanged changed the title OLF knitro solver extension Create OLF Knitro AC solver extension Nov 29, 2024
@jeandemanged jeandemanged mentioned this pull request Nov 29, 2024
Closed
7 tasks
@jeandemanged
delete unused test class
35d25e2 
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged
jeandemanged requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good.
After granting myself the permission (...) I did some cleanup. Don't hesistate to revert my changes if not ok.
Remains to do:

  • README to be filled explaining purpose and usage (look at other powsybl repositories for examples, eg OLF README). A knitro installation guide also would be welcome there.
  • CI with Knitro installation
  • sonar setup in CI

src/test/java/com/powsybl/openloadflow/knitro/solver/AcLoadFlowWithCachingTest.java Outdated Show resolved Hide resolved
@jeandemanged
0.1.0-snapshot
34b1f48 
Signed-off-by: Damien Jeandemange <[email protected]>
p-arvy
p-arvy reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@p-arvy p-arvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments.
Great job, @jeanneArchambault!
And thanks for your work, @jeandemanged, especially on the CI.

src/test/java/com/powsybl/openloadflow/knitro/solver/AcLoadFlow3wtTest.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverParameters.java Outdated Show resolved Hide resolved
...a-templates/com/powsybl/openloadflow/knitro/util/PowsyblOpenLoadFlowKnitroSolverVersion.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolver.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolver.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolver.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/knitro/solver/NonLinearExternalSolverUtils.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverFactory.java Outdated Show resolved Hide resolved
jeandemanged and others added 5 commits December 3, 2024 11:23
@jeandemanged
workaround kn finalization issue
5761e01 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
fix
1031f8d 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeanneArchambault
Clean
50e315f 
Signed-off-by: jarchambault <[email protected]>
@jeandemanged
fix
9839a31 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
Add CI
796a887 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
sonar cloud
c6591ae 
Signed-off-by: Damien Jeandemange <[email protected]>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

jeanneArchambault and others added 2 commits December 11, 2024 16:21
@jeanneArchambault
Clean
0cb79d2 
Signed-off-by: jarchambault <[email protected]>
@jeandemanged
Bump to OLF v1.14.0 and password protect Knitro download (#3)
893c86c 
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged and others added 10 commits December 12, 2024 22:28
@jeandemanged
fix license header vs package ordering
1cd8930 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
use bridj from maven central + readme update
dd0c0b9 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
add LICENSE, gitignore update
ef0a700 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
note on macOS
5aa77c9 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
note on knitro installation validation
b3d8f75 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeanneArchambault
Add cron every 5 min (test)
040f12a 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Merge branch 'init' of https://github.com/powsybl/powsybl-open-loadfl…
b5c6fb4 
…ow-knitro-solver into init
@jeanneArchambault
Solve sonarcloud issues
8f80054 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Add getter and setter for static field knitroParameters
d60cb87 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Delete useless equationId
ad4d31b 
Signed-off-by: jarchambault <[email protected]>
jeanneArchambault and others added 9 commits December 13, 2024 16:46
@jeanneArchambault
Update pom
156c4e1 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Modify knitroParameters (make it non static + make it a parameter of …
75153ee 
…CallbackEvalG)

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Revert "Update pom"
f00d8f7 
This reverts commit 156c4e1.
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Add tests for knitroParameters
354b026 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Delete cron + add test for Jacobian user routine + filter activated v…
f507ddf 
…ariables

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Undo unvoluntary setting user routine
e629bdd 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Modify gradient user routine test
c900cb8 
Signed-off-by: jarchambault <[email protected]>
@jeandemanged
better example Knitro output
ea4373d 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
clean
5e81640 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
clean
b802754 
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged
clean
ed78aaf 
Signed-off-by: Damien Jeandemange <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
116 New issues
1 Accepted issue

Measures
0 Security Hotspots
83.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jeandemanged jeandemanged merged commit ddef659 into main Dec 16, 2024
6 checks passed
@jeandemanged jeandemanged deleted the init branch December 16, 2024 09:34
p-arvy
p-arvy approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@p-arvy p-arvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you @jeanneArchambault @jeandemanged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-arvy p-arvy p-arvy approved these changes

@jeandemanged jeandemanged jeandemanged approved these changes

@Hadrien-Godard Hadrien-Godard Awaiting requested review from Hadrien-Godard

Assignees
No one assigned
Labels
Release 03/2025
Projects
Release 03/2025
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeanneArchambault @jeandemanged @p-arvy @alicecaron