Switch snapshot ci to new app and rework notification design #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
rolnico
changed the title
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
clementleclercRTE
approved these changes
Feb 3, 2025
|
Once merged, powsybl/powsybl-dev-tools#120 should be adapted to reflect the integration branch naming pattern change. |
olperr1
requested changes
Feb 5, 2025
Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
olperr1
requested changes
Feb 24, 2025
| core_snapshot_version=$(echo "$core_version" | grep -q SNAPSHOT && echo "$core_version" || echo "$core_version-SNAPSHOT") | ||
|
|
||
| # Find if an integration branch exists | ||
| INTEGRATION_BRANCH=$(git ls-remote --heads "$repo" | grep -E "refs/heads/integration/powsyblcore-$core_snapshot_version" | sed 's/.*refs\/heads\///') |
There was a problem hiding this comment.
After consulting the main repositories' maintainers, it was decided to keep non-protected branches for the CI snapshot process.
Can you change this script to use refs/heads/ci/core-$core_snapshot_version instead ("integration" -> "ci" + "powsyblcore" -> "core") and to remove references to "integration"?
Signed-off-by: Nicolas Rol <[email protected]>
# Conflicts: # .github/workflows/snapshot-ci.yml
Signed-off-by: Nicolas Rol <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
CI uses some action to format slack notification
What is the new behavior (if this is a feature change)?
Better format
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Existing integration branches for the current snapshot version of powsybl-core should be renamed by adding the prefix
ci/core-. (For instance,6.7.0-SNAPSHOT=>ci/core-6.7.0-SNAPSHOT).Other information:
6.6.0-SNAPSHOT). Now their name should be prefixed withintegration/powsyblcore-. In our previous example, the branches must be calledintegration/powsyblcore-6.6.0-SNAPSHOT.As a consequence, only maintainers can create these branches or force-push into them (see the branching strategy documentation).