-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch snapshot ci to new app and rework notification design #938
Open
rolnico
wants to merge
33
commits into
main
Choose a base branch
from
nro/switch_snapshot_CI_to_new_app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
642fb9a
rework CI snapshot
rolnico 3d50867
add print
rolnico deb2be3
add print
rolnico 29a03ff
add print
rolnico 47b4ffc
print
rolnico 5aed4a3
print
rolnico 4c83116
print
rolnico f10aafe
fix jobs name
rolnico 749336a
format results
rolnico f621b51
fix
rolnico 1f005dd
format
rolnico 482f072
test notification
rolnico 82be5be
remove comment
rolnico 68ff78d
remove unused variables
rolnico ccafd63
test with shorter message
rolnico c756b73
test with divided message
rolnico 98b0134
test with reduced message
rolnico f89a8d3
fix
rolnico 847b3a1
fix
rolnico d595990
fix
rolnico 897efc8
fix
rolnico 4e94816
fix
rolnico 2e09d14
add comments
rolnico f82f2d1
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico 3a443b4
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico f360017
fix step name
rolnico e76d3aa
fix actions versions
rolnico aaf7d88
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico 973c054
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico 9b72fe9
fix wheel directory
rolnico 086025f
change references from integration to snapshot
rolnico 61eec99
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico 0d8ecd5
fix
rolnico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#!/bin/bash | ||
|
||
repo=$1 | ||
core_version=$2 | ||
|
||
# Add "-SNAPSHOT" to powsybl-core version if not already there | ||
core_snapshot_version=$(echo "$core_version" | grep -q SNAPSHOT && echo "$core_version" || echo "$core_version-SNAPSHOT") | ||
|
||
# Find if an integration branch exists | ||
INTEGRATION_BRANCH=$(git ls-remote --heads "$repo" | grep -E "refs/heads/integration/powsyblcore-$core_snapshot_version" | sed 's/.*refs\/heads\///') | ||
if [ -n "$INTEGRATION_BRANCH" ]; then | ||
echo "SNAPSHOT VERSION EXIST: $INTEGRATION_BRANCH" | ||
echo "INTEGRATION_BRANCH=$INTEGRATION_BRANCH" >> "$GITHUB_ENV" | ||
else | ||
echo "No SNAPSHOT branch found" | ||
echo "INTEGRATION_BRANCH=main" >> "$GITHUB_ENV" | ||
fi |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After consulting the main repositories' maintainers, it was decided to keep non-protected branches for the CI snapshot process.
Can you change this script to use
refs/heads/ci/core-$core_snapshot_version
instead ("integration" -> "ci" + "powsyblcore" -> "core") and to remove references to "integration"?