Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch snapshot ci to new app and rework notification design #938

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
642fb9a
rework CI snapshot
rolnico Jan 28, 2025
3d50867
add print
rolnico Jan 28, 2025
deb2be3
add print
rolnico Jan 28, 2025
29a03ff
add print
rolnico Jan 28, 2025
47b4ffc
print
rolnico Jan 28, 2025
5aed4a3
print
rolnico Jan 28, 2025
4c83116
print
rolnico Jan 29, 2025
f10aafe
fix jobs name
rolnico Jan 29, 2025
749336a
format results
rolnico Jan 29, 2025
f621b51
fix
rolnico Jan 29, 2025
1f005dd
format
rolnico Jan 29, 2025
482f072
test notification
rolnico Jan 29, 2025
82be5be
remove comment
rolnico Jan 29, 2025
68ff78d
remove unused variables
rolnico Jan 29, 2025
ccafd63
test with shorter message
rolnico Jan 29, 2025
c756b73
test with divided message
rolnico Jan 29, 2025
98b0134
test with reduced message
rolnico Jan 30, 2025
f89a8d3
fix
rolnico Jan 30, 2025
847b3a1
fix
rolnico Jan 30, 2025
d595990
fix
rolnico Jan 30, 2025
897efc8
fix
rolnico Jan 30, 2025
4e94816
fix
rolnico Jan 31, 2025
2e09d14
add comments
rolnico Jan 31, 2025
f82f2d1
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico Jan 31, 2025
3a443b4
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico Jan 31, 2025
f360017
fix step name
rolnico Feb 5, 2025
e76d3aa
fix actions versions
rolnico Feb 5, 2025
aaf7d88
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico Feb 10, 2025
973c054
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico Feb 11, 2025
9b72fe9
fix wheel directory
rolnico Feb 11, 2025
086025f
change references from integration to snapshot
rolnico Feb 26, 2025
61eec99
Merge branch 'main' into nro/switch_snapshot_CI_to_new_app
rolnico Feb 26, 2025
0d8ecd5
fix
rolnico Feb 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/scripts/build_module.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

MODULE_NAME=$1
COMMAND=$2
CURRENT_OS=$3
CURRENT_PYTHON=$4

echo "Building $MODULE_NAME..."
$COMMAND
BUILD_EXIT=$?

if [ $BUILD_EXIT -ne 0 ]; then
echo "❌ $MODULE_NAME build FAILED" >> $BUILD_STATUS
printf 'BUILD_RESULT=%s;%s;%s;failure\n' "$CURRENT_OS" "$CURRENT_PYTHON" "$MODULE_NAME" >> "$GITHUB_OUTPUT"
else
echo "✅ $MODULE_NAME build SUCCESS" >> $BUILD_STATUS
printf 'BUILD_RESULT=%s;%s;%s;success\n' "$CURRENT_OS" "$CURRENT_PYTHON" "$MODULE_NAME" >> "$GITHUB_OUTPUT"
fi

exit $BUILD_EXIT
17 changes: 17 additions & 0 deletions .github/workflows/scripts/check_integration_branch.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/bin/bash

repo=$1
core_version=$2

# Add "-SNAPSHOT" to powsybl-core version if not already there
core_snapshot_version=$(echo "$core_version" | grep -q SNAPSHOT && echo "$core_version" || echo "$core_version-SNAPSHOT")

# Find if an integration branch exists
INTEGRATION_BRANCH=$(git ls-remote --heads "$repo" | grep -E "refs/heads/integration/powsyblcore-$core_snapshot_version" | sed 's/.*refs\/heads\///')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After consulting the main repositories' maintainers, it was decided to keep non-protected branches for the CI snapshot process.
Can you change this script to use refs/heads/ci/core-$core_snapshot_version instead ("integration" -> "ci" + "powsyblcore" -> "core") and to remove references to "integration"?

if [ -n "$INTEGRATION_BRANCH" ]; then
echo "SNAPSHOT VERSION EXIST: $INTEGRATION_BRANCH"
echo "INTEGRATION_BRANCH=$INTEGRATION_BRANCH" >> "$GITHUB_ENV"
else
echo "No SNAPSHOT branch found"
echo "INTEGRATION_BRANCH=main" >> "$GITHUB_ENV"
fi
15 changes: 0 additions & 15 deletions .github/workflows/scripts/check_snapshot_branch.sh

This file was deleted.

Loading
Loading