Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Daily_challenge #12392

Merged
merged 15 commits into from
Nov 30, 2024
Merged

Add Daily_challenge #12392

merged 15 commits into from
Nov 30, 2024

Conversation

Tenexxt
Copy link
Contributor

@Tenexxt Tenexxt commented Nov 3, 2024

Self-check

Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This article is a really good idea 👍

wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion

wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
@Tenexxt
Copy link
Contributor Author

Tenexxt commented Nov 4, 2024

I feel like I could squeeze some more info there, but i don't really know what.

Maybe the streak reward milestones?
I personaly stopped at day 90, but i feel like sharing the milestones in the wiki would be a great idea, since people are already looking for them in other places it would be just nice to allow people to always easly find them instead of everyone making a seperate post on redit or someone having to flood the main chat with an explanation when people could just link the wiki.

@Joehuu
Copy link
Member

Joehuu commented Nov 5, 2024

Maybe the streak reward milestones?

Do you mean tier colours? That's what it's called in the code: ppy/osu-web#11381

I think it should be in the wiki, else we only have a code reference. Should also mention that it appears on your profile (or not if you've never participated).

Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple more ideas, some of which are noted directly as a suggestion in the article.

I would like to open a discussion on a handful of topics as they concern a broader level.

General article structure

Putting the most important information at the top is crucial. I had the following in mind:

## Daily challenge

Notice: ...

The **daily challenge** is a multiplayer mode in osu!(lazer) where players are able to build up a *daily* streak by passing beatmaps consecutively with increasing difficulty.

(...)

Each day introduces one new handpicked beatmap from the featured artist listing. Regularly after one week however, the difficulty would be reset again.

(I'm struggling if there's anything else that should be mentioned here, like forced mod combinations)

## Game menu

(Explanation on how to play, and paragraph explaining the main menu)

## Beatmap difficulty range

(Image showing the various star rating ranges)

## Streak milestones

(Explained below)

## Trivia

Streak rewards

Like Joehuu already mentioned, I like the idea of adding the daily challenge popup in every user profile (from web) in the article, possibly with a screenshot.

Tiers for reference.

Daily and weekly series are shown in the user profile, with certain streak milestones decorating the popup in special colours.

(Screenshot)

(Table listing the tiers)

Consistent usage of tenses

The article should consistently use one tense. Though, this can be done as well after everything else has been settled.

wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
Copy link
Member

@Hiviexd Hiviexd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good article. would suggest listing the people who are responsible for running/curating things for transparency, given that's not mentioned anywhere right now.

can provide a list of said people if needed.

@Tenexxt
Copy link
Contributor Author

Tenexxt commented Nov 7, 2024

Game menu

(Explanation on how to play, and paragraph explaining the main menu)

So you want to merge the "How to play" and Main Menu paragraphs?
I can do that, tho I feel that the "Game menu" header doesn't really work then. An average person will normaly read the article and get the info on how to play even with the somewhat unfitting header, but i feel like this should be reworded if we're going to merge them, or atleast try to look for a better name (this is just my opinion of course).

Also made some placeholders for streak milestones and people running things

Co-Authored-By: The-Last-Cookie <[email protected]>
Copy link
Member

@Walavouchey Walavouchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this article should go in the Gameplay folder

wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
@Hiviexd
Copy link
Member

Hiviexd commented Nov 9, 2024

providing the list of contributors as requested on Discord.

organisation efforts are led by me, maps are picked by ChillierPear, Dada, FuJu, DeviousPanda, kingling, and Luscent.

wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Daily_challenge/en.md Outdated Show resolved Hide resolved
also now the article location is in `Gameplay` and I applied some sugested changes (thanks Agatem for help with the rank breakdown)

Co-Authored-By: Walavouchey <[email protected]>
Co-Authored-By: Agatem <[email protected]>
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
- Change line 3 and line 7 (current l3, l5 respectively) to contain information from line 5 and deletion of line 5

- Table "bug"-fixes

Co-Authored-By: The-Last-Cookie <[email protected]>
Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is almost ready to go.

Approving this PR after below points have been resolved.

wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Show resolved Hide resolved
- change wording in L5 and L59

Co-Authored-By: The-Last-Cookie <[email protected]>
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
Co-Authored-By: Agatem <[email protected]>
wiki/Gameplay/Daily_challenge/en.md Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Daily_challenge/en.md Outdated Show resolved Hide resolved
Co-authored-by: The-Last-Cookie <[email protected]>
Copy link
Contributor

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go from my side 👍

Hiviexd
Hiviexd previously approved these changes Nov 29, 2024
Add a link to `Relase_stream/Lazer`

Co-authored-by: Joseph Madamba <[email protected]>
Co-authored-by: Walavouchey <[email protected]>
@Hiviexd Hiviexd merged commit 8618b10 into ppy:master Nov 30, 2024
2 checks passed
@Tenexxt Tenexxt deleted the daily-challenge branch December 1, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants