Adjust daily challenge tier thresholds to match expectations #30906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2024
frenzibyte
reviewed
Nov 28, 2024
osu.Game/Overlays/Profile/Header/Components/DailyChallengeStatsTooltip.cs
Outdated
Show resolved
Hide resolved
frenzibyte
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See conversation in ppy/osu-wiki#12392 (comment)
Related to ppy/osu-web#11698
Color now changes when you reach the expected threshold, not surpass it.
Reason why rounding down instead of up in
TierForPlayCountis more correct is to ensure consistent behavior with web, and because current implementation causes unexpected behavior with tier assignment for playcount:Suppose I have
1079inplayCount, if we divide that by 3 we get359.6666666666667, which gets rounded up to360withMath.Ceiling(), therefore giving it an incorrect Lustrous tier while logic dictates that1080should be the minimum amount for said tier.