Update to .NET 8 + C# 12 #26957
Update to .NET 8 + C# 12 #26957
Conversation
| @@ -153,12 +153,12 @@ private struct ByHandleFileInformation | |||
| public static extern int link(string oldpath, string newpath); | |||
|
|
|||
| [DllImport("libc", SetLastError = true)] | |||
| private static extern int stat(string pathname, out struct_stat statbuf); | |||
| private static extern int stat(string pathname, out Stat statbuf); | |||
There was a problem hiding this comment.
For anyone else, explanation is that this triggers https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/warning-waves#cs8981---the-type-name-only-contains-lower-cased-ascii-characters.
Not sure how to feel about this change but don't think it's worth losing sleep over either.
|
.NET 8 ends support for Windows 8.1. Are we ending support for that? Maybe have some sort of tooling that can build .NET 6 for Windows 8.1 only and .NET 8 for the rest, but requires upkeep I would think and is probably not worth it as only 0.13% of steam users are still using it. Prereqs aren't updated in the readme. |
|
It looks like 8.1 is EOL so I would go ahead with dropping it. 
|
|
I've updated the system requirements in the readme. More concerning to me is that macOS 10.15 isn't supported anymore, which was the last x86-64 build of macOS. Curious what this means for that system and if it'll run at all anymore. If not... we may have to reconsider. |
|
Actually no. Their definition of supported means not-EOL operating systems, see dotnet/core#9038 (comment). Windows 8.1 and others could still work but may break whenever. Edit: still seems to run on Windows 8.1 |
|
Android needs attention (see action logs):
|
| "version": "6.0.100", | ||
| "rollForward": "latestFeature" | ||
| "version": "8.0.0", | ||
| "rollForward": "latestFeature", |
There was a problem hiding this comment.
I did have something to discuss around this.
If rollForward is set to major, it would allow higher SDK to be loaded, but lower version will still be preferred if present.
I know that Android/iOS workloads are more sensitive to SDK upgrades. I've faced similar problems with CsWinRT that patch updates of SDK broke things.
We may choose to pin Android/iOS workload verions instead.
There was a problem hiding this comment.
I wasn't intending to change anything here, just to update the version.
As far as I can tell, coreclr hasn't been really removing code for Windows 7. Simple programs will probably just work, but issues won't be fixed. The area needs most attention should be cryptographic. Old algorithms/APIs are going to be deprecated these years.
According to wikipedia and Apple support, macOS Monterey still supports x86-64 Mac, with some features unavailable. |
global.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "6.0.100", | |||
| "rollForward": "latestFeature" | |||
| "version": "8.0.0", | |||
There was a problem hiding this comment.
The SDK version should be 8.0.100.
There was a problem hiding this comment.
Does this change anything given it's latestFeature? This was changed automatically via Rider's SDK selection window.
There was a problem hiding this comment.
latestFeature should mean that all 8.0.xxx versions are valid.
The concern is that 8.0.0 is not valid SDK version number format. I've not found the global.json parsing code, but maybe something is depending on the format.
Prereqs: