-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.0 #57
Merged
Merged
Release v0.3.0 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] first part of implementation of adaptivity for scalar quantities * [WIP] more code for serial variant of adaptivity * [WIP] Further implementation of adaptivity * [WIP] Further code to handle checkpointing of adaptivity * Formatting * [WIP] Corrections to adaptivity code to get it to work with solver dummy * [WIP] Corrections to adaptivity implementation * Modifying data from micro dummy to ensure that not same data is transferred all the time * Corrections in adaptivity strategy * Add adaptivity to preCICE export output and add integration test for adaptivity (WIP) * Code corrections * Formatting * Formatting * Formatting * New strategy to avoid amending arrays which are being looped from inside of the loop * [WIP] Moving adaptivity functionality to a different class called AdaptiveController * [WIP] correcting mistake in similarity distance calculation * [WIP] close to working solution, solving active sims more smartly * Formatting * Resolving several errors in adaptivity code and moving to serial-explicit scheme for the adaptivity test * Working version of adaptivity test case * Fix solverdummy * [WORKING] First working version of adaptivity * Add adaptivity test to GitHub Actions CI * Formatting * Trying to get the GitHub Action for adaptivity to work * [WIP] Adding parallel variant of adaptivity * Move to using local data sets for adaptivity calculation * Add docstrings to adaptivity related functions and adjust integration test * Removing reference to a function which does not exist * Remove return type hint of type tuple
… same (#21) * Refactoring adaptivity functions into smaller and more readable functions. Adding unit test framework * Add unit test for get_similarity_dists function * Add unit tests for all functions related to adaptivity * Changing apt-get command flag and formatting * Add option to control if adaptivity is computed in every implicit iteration * Formatting * Remove unnecessary input parameter to output() functionality of micro sim * Get active and inactive micro sims more efficiently * Adaptivity seems to be working. Several bugs have been resolved * Cleaning code * Add new output variable adaptivity steps to count how many time steps is a micro sim active in * Add docstrings * Fixing several bugs for use when adaptivity is off * Solving bug for when adaptivity is not used, and some formatting * Fix incorrect variable name in MicroProblem class functions * Move the step to make all sims inactive outside of the time loop (obviously) * Adding docstrings for internal functions of adaptivity * Formatting * Add README for macro-micro-dummy and modfiy adaptivity part of main README
…log only number of active and inactive sims
…ing solverdummy (#22) * Add c++ dummy and move files * Add readme * Modify test action and add c++ dummy * Add some documentation * Rename micro_cpp_dummy file * Update action with new filename * Apply suggestions from code review Co-authored-by: Ishaan Desai <[email protected]> * Remove `get_dims` * Remove `_dims` * Move `micro-manager-config.json` to unify examples * Separate into c++ code into header file and code --------- Co-authored-by: Ishaan Desai <[email protected]>
* Do some syntax changes * Not use // as it may return float * Undo copy commit
* Make a copy of the active sim object which is associated to an inactive sim and put it in the list * Copy list of micro simulations in the association step and return the copied instance * Reduce total time of adaptivity integration test from 10 to 2 * Properly handling copying of active micro sim objects to the associated inactive ones
…emoving all settings
…Ds of the previously inactive simulation (#34)
* [WIP] Add pickling support to C++ solver dummy * Working example of pickling and unpickling of C++ solver dummy * Use py::tuple instead of std::tuple in examples/cpp-dummy/micro_cpp_dummy.cpp Co-authored-by: erikscheurer <[email protected]> * Use py::tuple instead of std::tuple in cpp solverdummy * Correcting wrongly removed code in cpp solver dummy * Remove template call to py::tuple * Remove unnecessary py::make_tuple call --------- Co-authored-by: erikscheurer <[email protected]>
…rning for global adaptivity
IshaanDesai
force-pushed
the
micro-manager-v0.3.0
branch
from
August 28, 2023 00:44
eb36209
to
fe55271
Compare
uekerman
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
This release is compatible with the Python bindings of preCICE: pyprecice v2.5.0.4.