Add Unit Tests for Element Conformance Warnings in ZAP File Import #1518
Conversation
ethanzhouyc
requested review from
paulr34,
tecimovic and
brdandu
as code owners
| // Their element conformance warnings should be added to the notification table. | ||
| expect( | ||
| notificationMessages.includes( | ||
| 'On endpoint 1, cluster: On/Off, command: OffWithEffect conforms to LT and is mandatory based on state of feature: LT.' |
There was a problem hiding this comment.
This message seems very confusing on what the user needs to(should) do. Change it to
On endpoint 1, cluster: On/Off, [incoming or outgoing] command: OffWithEffect needs to be enabled to ensure mandatory conformance with the enabled Lighting(LT) feature.
Or
'On endpoint 1, cluster: On/Off, [incoming or outgoing] command: OffWithEffect has mandatory conformance to Lighting(LT) feature and should be enabled when LT is enabled'
There was a problem hiding this comment.
Complicated conformance expressions have to be considered in the message, for example, LT | AB | element1. I will improve the message as below to cover all cases:
'On endpoint 1, cluster: On/Off, [incoming or outgoing] command: OffWithEffect has mandatory conformance to LT | AB | element1 and should be enabled when feature LT is enabled, feature AB is disabled, and element element1 is disabled'.
| ).toBeTruthy() | ||
| expect( | ||
| notificationMessages.includes( | ||
| 'On endpoint 1, cluster: On/Off, attribute: OnTime conforms to LT and is mandatory based on state of feature: LT.' |
There was a problem hiding this comment.
These also should be updated as above.
There was a problem hiding this comment.
Assuming the console warnings are already thrown out as well apart from the UI ones
importexport.test.jsto validate that non-conforming elements trigger warnings in the notification table when importing a ZAP file.multi-protocol.test.jsto account for element conformance warnings.Note:
This PR added conformance data to ZAP XML for testing purpose, which will make the “Device Type Features” button visible when running ZAP locally. However, in older Matter SDK versions without conformance data, the button will not be visible.