Add Unit Tests for Element Conformance Warnings in ZAP File Import

test/importexport.test.js

@@ -51,6 +51,10 @@ let provisionalCluster = path.join(
   __dirname,
   'resource/test-provisional-cluster.zap'
 )
+let nonConformElements = path.join(
+  __dirname,
+  'resource/non-conform-elements.zap'
+)
 
 // Due to future plans to rework how we handle global attributes,
 // we introduce this flag to bypass those attributes when testing import/export.
@@ -470,3 +474,45 @@ test(
   },
   testUtil.timeout.medium()
 )
+
+test(
+  'Import a ZAP file with elements that do not conform to a device type feature and make sure element conformance warnings show up in the notification table',
+  async () => {
+    sid = await querySession.createBlankSession(db)
+    await util.ensurePackagesAndPopulateSessionOptions(
+      templateContext.db,
+      sid,
+      {
+        zcl: env.builtinSilabsZclMetafile(),
+        template: env.builtinTemplateMetafile()
+      },
+      null,
+      [templatePkgId]
+    )
+    await importJs.importDataFromFile(db, nonConformElements, {
+      sessionId: sid
+    })
+    expect(sid).not.toBeUndefined()
+    let notifications = await sessionNotification.getNotification(db, sid)
+    let notificationMessages = notifications.map((not) => not.message)
+
+    // Two attributes and one command conform to the enabled device type feature 'LT' but are disabled.
+    // Their element conformance warnings should be added to the notification table.
+    expect(
+      notificationMessages.includes(
+        'On endpoint 1, cluster: On/Off, command: OffWithEffect conforms to LT and is mandatory based on state of feature: LT.'
+      )
+    ).toBeTruthy()
+    expect(
+      notificationMessages.includes(
+        'On endpoint 1, cluster: On/Off, attribute: OnTime conforms to LT and is mandatory based on state of feature: LT.'
+      )
+    ).toBeTruthy()
+    expect(
+      notificationMessages.includes(
+        'On endpoint 1, cluster: On/Off, attribute: GlobalSceneControl conforms to LT and is mandatory based on state of feature: LT.'
+      )
+    ).toBeTruthy()
+  },
+  testUtil.timeout.medium()
+)

test/multi-protocol.test.js

@@ -206,10 +206,37 @@ test(
       )
     ).toBeTruthy()
 
-    // Just one notification regarding multiple top level zcl propertoes and 4
-    // notifications regarding feature map attribute not set correctly
-    // and one notification regarding the enabled provisional cluster: Scenes
-    expect(sessionNotifications.length).toEqual(6)
+    // Tests for provisional cluster warnings
+    expect(
+      sessionNotificationMessages.includes(
+        'On endpoint 1, support for cluster: Scenes server is provisional.'
+      )
+    ).toBeTruthy()
+
+    // Tests for the attributes and commands that do not conform to the device type feature LT
+    let nonConformElements = [
+      { name: 'StartUpOnOff', type: 'attribute' },
+      { name: 'OffWaitTime', type: 'attribute' },
+      { name: 'OnTime', type: 'attribute' },
+      { name: 'GlobalSceneControl', type: 'attribute' },
+      { name: 'OffWithEffect', type: 'command' },
+      { name: 'OnWithRecallGlobalScene', type: 'command' },
+      { name: 'OnWithTimedOff', type: 'command' }
+    ]
+
+    for (const element of nonConformElements) {
+      expect(
+        sessionNotificationMessages.includes(
+          `On endpoint 1, cluster: On/Off, ${element.type}: ${element.name} conforms to LT and is not supported based on state of feature: LT.`
+        )
+      ).toBeTruthy()
+    }
+
+    // one notification regarding multiple top level zcl propertoes
+    // 4 notifications regarding feature map attribute not set correctly
+    // one notification regarding the enabled provisional cluster
+    // 7 notifications regarding non-conformed elements
+    expect(sessionNotifications.length).toEqual(13)
 
     // Test Accumulators in templates
     let zigbeeEndpointEvents = genResultZigbee.content['zap-event.h']