Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output more context on error #60

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Also fixes (and adapts to) our spec.s as per elvis_core.

The added test is a dumb one, not unlike the prior version of it, but it makes sure we don't crash on function call (mimics rebar3) and on io:format'ing it.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Oh, yeah, this'll fail until we release inaka/elvis_core#332. I'll move it to draft, for now.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft January 17, 2024 23:47
The test is a dumb one, not unlike the prior version of it,
but it makes sure we don't crash on function call (mimics
rebar3) and on io:format'ing it
@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review January 18, 2024 14:37
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Moving to Ready to review as CI is no longer broken, and I've up'ed elvis_core to 3.2.1. After this I can release here and in Hex.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit b040918 into master Jan 18, 2024
6 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/report-first-exception branch January 18, 2024 16:50
@paulo-ferraz-oliveira
Copy link
Collaborator Author

3.2.1 published in GitHub and Hex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants