Use linear decode output buffer in the hybrid-GPU case #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Improper Commit Message |
sysopenci
added
Pending Developer Approval
|
Improper Commit Message |
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
yaoxinshi-intel,
YuanjunHuang and
yyao3
feijiang1
reviewed
Nov 5, 2024
TianmiChen
reviewed
Nov 6, 2024
sysopenci
added
Valid commit message
and removed
Valid commit message
PR approved
labels
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
yaoxinshi-intel,
YuanjunHuang and
yyao3
phreer
changed the title
In hybrid GPU case, video decoder could be iGPU and the coded images would be consumed by dGPU. Unfortunately, it's likely that we can hardly find a tiling format supported by both of them. To achieve best compatibility and make our life better, simply use linear buffers for decoded images. By setting CPU_READ and CPU_WRITE flags, we force OneVPL to allocate internal buffers and blit decoded content to external buffers. In this way we can work around hardware limitation that DG2 cannot decode to linear buffers. We will detect the GPU group type and decide whether to use linear buffers or not. Tracked-On: OAM-126399 Signed-off-by: Weifeng Liu <[email protected]>
sysopenci
removed request for
dyang23,
gkdeepa,
TianmiChen,
yaoxinshi-intel,
YuanjunHuang and
yyao3
|
Close with #202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hybrid GPU case, video decoder could be iGPU and the coded images would be consumed by dGPU. Unfortunately, it's likely that we can hardly find a tiling format supported by both of them. To achieve best compatibility and make our life better, simply use linear buffers for decoded images.
By setting CPU_READ and CPU_WRITE flags, we force OneVPL to allocate internal buffers and blit decoded content to external buffers. In this way we can work around hardware limitation that DG2 cannot decode to linear buffers.