Disallow missing resource docs on upgrades #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
changed the title
VenelinMartinov
changed the base branch from
master
to
vvm/dont_auto_merge_upstream_upgrades
thomas11
approved these changes
Feb 11, 2025
VenelinMartinov
merged commit 0cd2d88
into
vvm/dont_auto_merge_upstream_upgrades
7 checks passed
VenelinMartinov
added a commit
that referenced
this pull request
Feb 11, 2025
This reverts commit 0cd2d88.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## vvm/dont_auto_merge_upstream_upgrades #3003 +/- ##
=====================================================================
Coverage 0.00% 0.00%
=====================================================================
Files 2 2
Lines 4 4
=====================================================================
Misses 4 4 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
added a commit
that referenced
this pull request
Feb 11, 2025
Standing this up again as I accidentally merged #3003 into the other branch. Sets the `allowMissingDocs` ci-mgmt config to false to error on missing resource docs. This maintains the current behaviour. Part of pulumi/upgrade-provider#303
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Feb 11, 2025
This PR changes all Tier2+ providers to allow missing resource docs when running a provider upgrade. This is a common issue which happens and we have to manually work around. Fixes pulumi/upgrade-provider#303 Tier 1 providers are exempt as the config is explicitly false there: pulumi/pulumi-gcp#2971 pulumi/pulumi-aws#5193 pulumi/pulumi-azure#3003 pulumi/pulumi-azuread#1877
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Feb 12, 2025
This PR changes all Tier2+ providers to allow missing resource docs when running a provider upgrade. This is a common issue which happens and we have to manually work around. Fixes pulumi/upgrade-provider#303 Tier 1 providers are exempt as the config is explicitly false there: pulumi/pulumi-gcp#2971 pulumi/pulumi-aws#5193 pulumi/pulumi-azure#3003 pulumi/pulumi-azuread#1877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
allowMissingDocsci-mgmt config to false to error on missing resource docs. This maintains the current behaviour.Part of pulumi/upgrade-provider#303