Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulty IPv6 example #1523

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Dec 9, 2024

Proposed changes

The existing IPv6 example is wrong and untested. Creating a working example requires additional changes (like ensuring the nodes can perform ec2:AssignIpv6Addresses).

This removes the faulty and untested example in order to not create frustration and confusion for users. We'll need to separately work on creating a proper IPv6 example (#1522).

Related issues (optional)

Relates to #1522

@flostadler flostadler requested review from t0yv0, corymhall and a team December 9, 2024 10:29
@flostadler flostadler self-assigned this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@flostadler flostadler enabled auto-merge (squash) December 9, 2024 13:49
@flostadler flostadler merged commit 7297e8f into master Dec 9, 2024
34 checks passed
@flostadler flostadler deleted the flostadler/remove-ipv6-example branch December 9, 2024 13:51
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants