Fix headings and change div to span

puzzle · Oct 18, 2024 · 2dbeaa4 · 2dbeaa4
1 parent e242be3
commit 2dbeaa4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html b/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html
@@ -9,13 +9,13 @@ <h3 class="title">{{ keyResult.title }}</h3>
       </div>
       <div class="me-3">
         <section class="d-flex justify-content-between mb-3">
-          <div>
+          <span>
             {{ "KEY_RESULT_TYPE." + keyResult.keyResultType | translate }}
-          </div>
-          <div class="d-flex align-items-center">
+          </span>
+          <span class="d-flex align-items-center">
             <img alt="person icon" class="me-1" height="10" src="../../../assets/icons/person-icon.svg" width="10" />
             <p *ngIf="keyResult.owner as owner">{{ owner.firstname }} {{ owner.lastname }}</p>
-          </div>
+          </span>
           <span *ngIf="keyResult?.objective?.quarter as quarter">{{ quarter.label }}</span>
         </section>
 
@@ -101,7 +101,7 @@ <h2 class="sub-title-keyresult-detail fw-bold mb-1">
         </section>
 
         <div class="mt-3 mb-4">
-          <h2 class="sub-title-keyresult-detail fw-bold mb-1">Beschrieb</h2>
+          <h4 class="sub-title-keyresult-detail fw-bold mb-1">Beschrieb</h4>
           <p class="linebreak" *ngIf="keyResult.description === ''">-</p>
           <p class="linebreak" *ngIf="keyResult.description !== ''">{{ keyResult.description }}</p>
         </div>

diff --git a/frontend/src/app/components/objective-detail/objective-detail.component.html b/frontend/src/app/components/objective-detail/objective-detail.component.html
@@ -2,7 +2,7 @@
   <ng-container *ngIf="(objective$ | async)?.id && (objective$ | async) as objective; else spinner">
     <div *ngIf="objective" class="d-flex flex-column">
       <div class="w-100 d-flex justify-content-between align-items-center mb-3">
-        <h2 class="title">{{ objective.title }}</h2>
+        <h3 class="title">{{ objective.title }}</h3>
         <button
           class="d-flex align-items-center justify-content-center"
           mat-icon-button
@@ -14,7 +14,7 @@ <h2 class="title">{{ objective.title }}</h2>
       </div>
 
       <section class="me-3">
-        <p class="sub-title-objective fw-bold mb-1">Beschrieb</p>
+        <h4 class="sub-title-objective fw-bold mb-1">Beschrieb</h4>
         <div class="linebreak" *ngIf="objective.description === ''"><p>-</p></div>
         <div *ngIf="objective.description !== ''" data-test-id="description" class="linebreak">
           <p>{{ objective.description }}</p>