fix eslint errors

puzzle · Dec 23, 2024 · b3cf0ff · b3cf0ff
1 parent 85a08b0
commit b3cf0ff
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.ts b/frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.ts
@@ -62,7 +62,7 @@ export class KeyresultDialogComponent {
         id: this.data.keyResult?.id
       } as KeyResultOrdinalDTO;
     keyResult.id = this.data.keyResult?.id;
-    keyResult.version = this.data.keyResult?.version!;
+    keyResult.version = this.data.keyResult.version!;
     keyResult.actionList = keyResult.actionList!.filter((action: Action) => action.action !== '');
     this.keyResultService.saveKeyResult(keyResult)
       .subscribe((returnValue) => {

diff --git a/frontend/src/app/shared/common.ts b/frontend/src/app/shared/common.ts
@@ -46,7 +46,7 @@ export function isLastCheckInNegative(baseline: number, stretchGoal: number, val
 }
 
 export function calculateCurrentPercentage(keyResultMetric: KeyResultMetricMin): number {
-  const value: number = +keyResultMetric.lastCheckIn?.value!;
+  const value: number = +keyResultMetric.lastCheckIn!.value!;
   const baseline: number = +keyResultMetric.baseline;
   const stretchGoal: number = +keyResultMetric.stretchGoal;
   if (isLastCheckInNegative(baseline, stretchGoal, value)) {

diff --git a/frontend/src/app/shared/custom/scoring/scoring.component.spec.ts b/frontend/src/app/shared/custom/scoring/scoring.component.spec.ts
@@ -163,7 +163,7 @@ describe('ScoringComponent', () => {
       component.failPercent = 0;
 
       // Set zone
-      (component.keyResult.lastCheckIn as CheckInOrdinalMin)!.zone! = object.zoneValue;
+      (component.keyResult.lastCheckIn as CheckInOrdinalMin)!.zone = object.zoneValue;
       component.calculatePercentageOrdinal();
 
       // Verify if percentage was set correctly