Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/863 Objektive Abschluss Kommentar anzeigen #1273

Merged
merged 27 commits into from
Jan 14, 2025
Merged

Feature/863 Objektive Abschluss Kommentar anzeigen #1273

merged 27 commits into from
Jan 14, 2025

Conversation

Miguel7373
Copy link
Collaborator

No description provided.

@Miguel7373 Miguel7373 force-pushed the feature/863-show-objective-completed-comment branch from a57376a to bfb9128 Compare January 7, 2025 10:05
@Miguel7373 Miguel7373 linked an issue Jan 7, 2025 that may be closed by this pull request
Objektive Abschluss Kommentar anzeigen #863
Closed
4 tasks
@Miguel7373 Miguel7373 force-pushed the feature/863-show-objective-completed-comment branch from 694ef76 to c259a49 Compare January 9, 2025 12:52
@kcinay055679
Copy link
Collaborator

  • Whenever an ongoing Objective is clicked, spring throws an error complaing that completed is null. Why is completed even queried for an ongoing objective?

  • If you access an objective you just completed as successful (and only then) angular throws errors:
    image

@Miguel7373 Miguel7373 force-pushed the feature/863-show-objective-completed-comment branch from 8453811 to c0e54e9 Compare January 13, 2025 14:49
@Miguel7373 Miguel7373 marked this pull request as ready for review January 14, 2025 07:15
peggimann
peggimann previously approved these changes Jan 14, 2025
View reviewed changes
Miguel7373 and others added 17 commits January 14, 2025 10:34
@Miguel7373
add backend request for completed with unit tests
1d0dd01
@Miguel7373
display the completed comment in the frontend
f9013eb
@Miguel7373
update import
9d5711b
@Miguel7373
backend formatting changes
c12ef1a
@Miguel7373
remove 404 in the completed get request
ab1b1d3
@Miguel7373
apply backend formatter
f33357a
@Miguel7373
inclued test for the completed comment
7f67420
@ManuelMoeri
Fix naming of endpoint and the corresponding documentation and add be…
c0ccc8a 
…tter spacing to frontend
@ManuelMoeri
Rename service with typo, fix naming of e2e tests and change some log…
89427ee 
…ic in the frontend
@ManuelMoeri
Try to generalize cypress testing
7fd7d6d
@ManuelMoeri
Fix e2e tests by using correct state for selecting the objectives
eb0144f
@ManuelMoeri
Finish abstraction of completeDialog in e2e testing
3acd7f5
@Miguel7373
add unit test for completed
d24859f
@Miguel7373
add right role check for get of completed
0b1d06b
@Miguel7373
fix unit test to use right state
3f1e4ca
@Miguel7373
fix completed is undefined error by not loading in always
c88e2dc
@Miguel7373
fix takeUntilDestroy
ed39406
@peggimann peggimann force-pushed the feature/863-show-objective-completed-comment branch from b5ee444 to cfbcc41 Compare January 14, 2025 09:35
@peggimann peggimann merged commit 784a738 into main Jan 14, 2025
19 checks passed
@peggimann peggimann deleted the feature/863-show-objective-completed-comment branch January 14, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peggimann peggimann peggimann approved these changes

@kcinay055679 kcinay055679 kcinay055679 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objektive Abschluss Kommentar anzeigen
4 participants
@Miguel7373 @kcinay055679 @peggimann @ManuelMoeri