Avoid double impurity calculation inside criterion.pyx in tree module #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdaiha
force-pushed
the
improve-causal-forest
branch
from
9030a93
to
e1c1498
Compare
Signed-off-by: Keith Battocchi <[email protected]> Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
until dependencies are available. Signed-off-by: Keith Battocchi <[email protected]> Signed-off-by: Gabriel Daiha <[email protected]>
…y-why#879) * Fixed normal inference results confidence interval unnecessary loop Signed-off-by: gdaiha <[email protected]> Signed-off-by: Gabriel Daiha <[email protected]> Signed-off-by: Gabriel Daiha <[email protected]>
Increase sample size to reduce errors Signed-off-by: kgao <[email protected]> Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
gdaiha
force-pushed
the
improve-causal-forest
branch
from
b600149
to
1d44cef
Compare
|
Can't understand exactly why these tests are failing. The only thing I've done here was to move impurity_improvement after the calculation of best.impurity_left and best.impurity_right and changed impurity_improvement signature. Tests are claiming for errors in shape of outputs of grf and cf tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/scikit-learn/scikit-learn/pull/18203/files# in Sklearn`s RandomForest, this PR aims to avoid double calculation of impurity inside criterion.pyx of tree module