Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double impurity calculation inside criterion.pyx in tree module #885

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Avoid double impurity calculation inside criterion.pyx in tree module #885

wants to merge 11 commits into from

Commits on May 10, 2024

  1. Use environments for additional deployment safety 

    Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
    @kbattocchi @gdaiha
    kbattocchi authored and gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    62e84ec View commit details
    Browse the repository at this point in the history

  2. Avoid double impurity calculation 

    Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4309e84 View commit details
    Browse the repository at this point in the history

  3. moved comment inside criterion.pyx 

    Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c00b8cf View commit details
    Browse the repository at this point in the history

  4. removed unused self.honest condition 

    Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3164b7c View commit details
    Browse the repository at this point in the history

  5. Use macos-12 instead of macos-latest to avoid ARM 

    until dependencies are available.

Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
    @kbattocchi @gdaiha
    kbattocchi authored and gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c88a348 View commit details
    Browse the repository at this point in the history

  6. Optimizing NormalInferenceResults confidence interval method speed (p… 

    …y-why#879)

* Fixed normal inference results confidence interval unnecessary loop

Signed-off-by: gdaiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    390287c View commit details
    Browse the repository at this point in the history

  7. Fix flaky RScorer test (py-why#876) 

    Increase sample size to reduce errors

Signed-off-by: kgao <[email protected]>
Signed-off-by: Gabriel Daiha <[email protected]>
    @kgao @gdaiha
    kgao authored and gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    546ecc8 View commit details
    Browse the repository at this point in the history

  8. fixed criterion.pxd with new signature 

    Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    727bba9 View commit details
    Browse the repository at this point in the history

  9. fixed types in impurity_improvement definition in criterion 

    Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0df03b6 View commit details
    Browse the repository at this point in the history

  10. removed best.improvement from is_children_impurity_proxy condition 

    Signed-off-by: Gabriel Daiha <[email protected]>
    @gdaiha
    gdaiha committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1d44cef View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into improve-causal-forest

    @gdaiha
    gdaiha authored May 10, 2024
    Configuration menu
    Copy the full SHA
    c81e24e View commit details
    Browse the repository at this point in the history