Replace try-except block by if-else statement #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The current code uses a
try-except
block to handle a potentialKeyError
when looking up a color value in theCOLORS_BY_VALUE
andCOLORS_BY_NAME
dictionary:Proposed Change:
Refactor the code to use an
if-else
conditional check instead of atry-except
block. This change improves code readability and leverages a more predictable conditional flow:Benefits:
Impact:
This change is expected to maintain the existing functionality while improving code clarity.
Please let me know if there are any specific tests or cases you would like me to address in this refactoring.
Thank you!