Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain name string type #212

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Conversation

matter1-git
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e186814) to head (816dcc4).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #212    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        19     +8     
  Lines          685      1047   +362     
  Branches       169       253    +84     
==========================================
+ Hits           685      1047   +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @matter1-git Thanks for your work, i left some comments for you, I'm happy to discuss anything around this.

also can you add to test_json_schema.py this code:

        (
            DomainStr,
            {
                'title': 'Model',
                'type': 'object',
                'properties': {
                    'x': {
                        'title': 'X',
                        'type': 'string',
                    },
                },
                'required': [
                    'x',
                ],
            },
        ),

pydantic_extra_types/domain.py Show resolved Hide resolved
tests/test_domain.py Outdated Show resolved Hide resolved
@matter1-git
Copy link
Contributor Author

I have added the suggested changes and test cases. 🚀

Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yezz123 yezz123 merged commit 55a01b2 into pydantic:main Sep 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants