-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INF] Set multi-test env to compat dependency and system #1143
base: dev
Are you sure you want to change the base?
Conversation
Why does the test action don't work? |
I think it's because the PR is a draft, maybe? |
I opened this PR and pushed an empty commit, but it still can't trigger test ci. |
It seems these functions really have problems. Need to fix:
I will have a look at |
only test documentation in documentation building CI
I just skip tests/test_documentation_build.py. EDIT: done #1183 |
for more information, see https://pre-commit.ci
… into ci/testing-env
This goal will be done at the next PR.
It's ready to be reviewed. |
d13fb8d
to
2405a07
Compare
… into ci/testing-env
0032159
to
0249ce8
Compare
Why these py3.8 envs didn't get error? |
… into ci/testing-env
@Zeroto521 I'm not sure why, but I think testing on py3.8 might become less relevant once py3.12 is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zeroto521 only one set of change requests from me, the other being a question for you to address (but not necessarily act on in this PR).
Thank you for helping out here!
- "3.8" | ||
- "3.9" | ||
- "3.10" | ||
env: [ci/envs/latest.yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zeroto521 would you recommend also testing on the development environment as defined in environment-dev.yml
?
run: pytest -v -r a -n auto --color=yes --durations=0 --cov=janitor --cov-append --cov-report term-missing --cov-report xml tests -m "not turtle" | ||
|
||
- name: Run turtle unit tests | ||
run: pytest -v -r a -n auto --color=yes --durations=0 --cov=janitor --cov-append --cov-report term-missing --cov-report xml tests -m "turtle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically we've been able to reduce testing time by running the turtle
and not turtle
tests in parallel. Codecov will also get updated correctly as long as --cov-append
is called, if I remember correctly. Can we reinstate running turtle
and not turtle
tests here, please?
PR Description
Please describe the changes proposed in the pull request:
Aim:
ToDo/Doing:
Part of #1133
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.