[ENH] More control on creating the output dataframe for conditional_join - PR no 1
#1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1396--pyjanitor.netlify.app |
added 9 commits
September 7, 2024 13:02
This was referenced Sep 7, 2024
ericmjl
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of a series of PRs to improve conditional_join, with the final aim being to support aggregations within conditional_join. Supporting aggregations within conditional_join means we can avoid materializing the dataframe before aggregating, and should generally improve performance for such operations.
PR Description
Please describe the changes proposed in the pull request:
This PR relates to #1269 .
Please tag maintainers to review.