-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft modular config structure #1174
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is indeed a great draft. Clearly this is not (yet) integrated as a workflow, but it is a great proposal.
It will have implications to the other repo (-distribution and alike), but it is a great proposal in my opinion, and we need to start :)
We can reflect on the naming, for example:
- geometry may be replaced with spatial
- weather may be replaced with load_weather or alike; just to clarify also the load option.
They are quite many files; I am wondering if the sector configs may be merged (e.g. heating/hydrogen/transport) into a config.sector.yaml for example
Moreover, I'm wondering about the "main" settings of the scenario, run and enable keys for example; maybe a "header" config may be interesting to aggregate some of those options?
It would be great to collect ideas
This reverts commit a054730.
Thank you so much for looking into that @davide-f! Happy to hear that you like it 🙂 I expect that it'll take some iterations to find a convenient and robust approach to deal with the configs. But it feels easier to think about different options when playing with a possible implementation. So, let's experiment with that! Agree that it would be cleaner to keep a reasonable number of the modular configs. Have renamed
Not sure it would increase clarity if we add Absolutely agree that we need also to think about management of the configuration files, also keeping in mind the requirements of the distribution model. A great point on having a header file. Happy to implement that and have to find a proper way to do so 😄 That directly relates to creating a good architecture, and I'd be very grateful for your support in that. |
Some additionally points which would be great to discuss are:
Obviously, more ideas are welcome |
As discussed previously, it would be also great to add a parser for the config to check it for consistency. The requirements can include:
|
An attempt to organise the configuration file in a readable way
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.