fix(detections): allow azimuth = 0

[RonanMorgan]

Currently there is an error if the azimuth is defined equal to 0

Close #395

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (7a0dcd7) to head (60b016b).
Report is 14 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files          35       35           
  Lines         996      996           
=======================================
  Hits          845      845           
  Misses        151      151           

Flag	Coverage Δ
backend	84.35% <100.00%> (ø)
client	92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MateoLostanlen]

Hi @RonanMorgan , thanks a lot for the fix

[frgfm]

Thanks for the PR! I added a suggestion because if we merged this modification we'll get ]-1,360[ (floats, not integers), but we want [0,360[

[frgfm]

Thanks! Only one concern: I can't figure out why the docker build job fails 🤔 (it's working on main)
Worth checking before merging

[RonanMorgan]

@frgfm I don't have any issue locally but it seems to me that the backend stay unhealthy longer than 30sec, can I change this parameters ? :

  interval: 10s
  timeout: 3s
  retries: 3

[frgfm]

@RonanMorgan yes but if you do, only increase the number of retries please 🙏

[RonanMorgan]

ok I just remove the docker-compose;yml file and replaced it by docker-compose.dev;yml (which make sense now since there is a production docker-compose in ansible)

I think it was a variable error since there are default values in this one

[frgfm]

Changing the docker env var values is quite alright and removing the somehow duplicate compose, but not too sure about removing alembic and volume binding for the DB & localstack?

This would make the docker compose solely a "test" compose, because there is no data persistence and we don't create migrations. is this a good idea? 🤔 (it fixes the CI, but my question is: won't this reduce the usability of the project?)

[RonanMorgan]

well is this used for anything else than test ? :)

I have an other docker-compose for any production usage in ansible, I think this should be enough (?)

[frgfm]

I have an other docker-compose for any production usage in ansible, I think this should be enough (?)

Question of perspective, I'm open to both. Until now, we've made sure the repo had something for the dev to "try locally" what production would do, and run tests as well. You think it's not worth it?

[RonanMorgan]

I think that's worth it but in this case we need to add Treaefik and test it regularly in a new vm. For me the docker-compose I removed was too far from the production one to be more useful than the .dev. one

[frgfm]

Ok, let's first finish this PR topic: why in the first place did we need to change so many files to have the CI work 🤔
Especially because the CI has had no problem on main for a while. For last few PRs, we didnt have to change anything on docker or the CI config to get it to pass. If we could have that minimal change, that would awesome 👌

[frgfm]

I tried my best to rebase the PR but several conflicts were a bit tideous so I created #414
Closing this one since this is now handled, thanks again!