Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detections): allow azimuth=0 for the detection table #414

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jan 16, 2025

I couldn't rebase properly #399 so I went minimal with this one. This updates the lower bound constraint on azimuth value and add a test case

close #395

@frgfm frgfm added the type: fix Something isn't working label Jan 16, 2025
@frgfm frgfm marked this pull request as ready for review January 16, 2025 15:07
@frgfm frgfm self-assigned this Jan 16, 2025
@frgfm frgfm merged commit ccd95d2 into main Jan 16, 2025
25 checks passed
@frgfm frgfm deleted the frgfm/azimuth-range branch January 16, 2025 15:07
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (3ac2cd1) to head (402d1f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files          38       38           
  Lines        1053     1053           
=======================================
  Hits          901      901           
  Misses        152      152           
Flag Coverage Δ
backend 85.15% <ø> (ø)
client 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azimuth can be zero
1 participant