Fix invalid-range-index bug
#969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-yz-liu
reviewed
Oct 8, 2023
There was a problem hiding this comment.
@ch-iv thanks for making this pull request! I left a few quick comments inline.
In addition to those:
- Please update this branch from
master; you'll find when merging that I've added a "Bug Fixes" subsection underneath "Unreleased", and you can add your CHANGELOG entry underneath that. - If you'd like to be recognized for your work, please add your name to the list of contributors in the README file :)
# Conflicts: # CHANGELOG.md
|
@david-yz-liu Thanks for the feedback. I just pushed all the suggested fixes to the branch. |
Pull Request Test Coverage Report for Build 6451309517
💛 - Coveralls |
david-yz-liu
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
InvalidRangeIndexCheckerwould incorrectly identify invalid range calls. This PR also implements tests to test the fix. Fixes #967Motivation and Context
It solves an issue some students in CSC110 were having with range calls.
The range produces more than 1 value, however it is flagged as invalid regardless.
Your Changes
Implement a correct way of checking range calls.
Description:
Type of change (select all that apply):
Testing
Tested with hypothesis for correctness. Also unit tests provided.
Checklist